29 replies to this topic

[ViroMan]

Quote

Btw, it was helpful when the log showed the deletions, nice to see it, apparently not anymore, the command was changed.

They stopped showing? Will look into it. Probably just a minor change to the log stopped making it show. I have been modifying the logging a lot lately.

edit:
So I looked into the code. It says it will always show deletes. I duno why it won't show for you.

The code goes...
If file exists
. add log message
. delete file

Edited by ViroMan, 01 April 2013 - 12:02 AM.

[DesertJerry]

_def_x_, on 31 March 2013 - 09:00 PM, said:

As I mentioned in post #14, the fixed script is on the release2.list. In a newer APUP (I used 1.4.14), change the URL to - http://www.autopatch.../releases2.list - click 'OK'. The list should load. There's about 13 scripts and 1 Office Addon. These scripts are to test so VM needs your input, once the changes are good to go then it will be moved to the main list.

As I said earlier - I ran APUP 1.4.14 with Options set to Releases2.list and I selected the Office update - I did not get the _v2 version.

[_def_x_]

ViroMan, on 31 March 2013 - 11:26 PM, said:

They stopped showing? Will look into it. Probably just a minor change to the log stopped making it show. I have been modifying the logging a lot lately.

edit:
So I looked into the code. It says it will always show deletes. I duno why it won't show for you.

The code goes...
If file exists
. add log message
. delete file

Doesn't look like the latest APUP (1.4.14) code overrides the commands in the script, some will write to the log, others wont. The Adobe Reader 11 script is a good simple example - http://www.autopatch...20130221.script

These "should" write to the log file:

PreAction=del /q "autopatcher:\modules\stand_alone\AdbeRdr1101_en_US.apm
PreAction=rmdir /S /Q "autopatcher:\modules\stand_alone\AdbeRdr1101_en_US.apm_files
PreAction=del /q "autopatcher:\modules\stand_alone\AdbeRdr1100_en_US.apm
PreAction=rmdir /S /Q "autopatcher:\modules\stand_alone\AdbeRdr1100_en_US.apm_files
PreAction=move /y "autopatcher:\modules\stand_alone\AdbeRdr11002_en_US.apm_files" "autopatcher:\modules\stand_alone\AdbeRdr1102_en_US.apm_files"

...but not these:

PreAction.FileDelete=autopatcher:\modules\stand_alone\AdbeRdr1010_en_US.apm
PreAction.FolderDelete=autopatcher:\modules\stand_alone\AdbeRdr1010_en_US.apm_files
PreAction.FileDelete=autopatcher:\modules\stand_alone\AdbeRdr1011_en_US.apm
PreAction.FolderDelete=autopatcher:\modules\stand_alone\AdbeRdr1011_en_US.apm_files
PreAction.FileDelete=autopatcher:\modules\stand_alone\AdbeRdr1012_en_US.apm
PreAction.FolderDelete=autopatcher:\modules\stand_alone\AdbeRdr1012_en_US.apm_files
PreAction.FileDelete=autopatcher:\modules\stand_alone\AdbeRdr1013_en_US.apm
PreAction.FolderDelete=autopatcher:\modules\stand_alone\AdbeRdr1013_en_US.apm_files
PreAction.FileDelete=autopatcher:\modules\stand_alone\AdbeRdr1014_en_US.apm
PreAction.FolderDelete=autopatcher:\modules\stand_alone\AdbeRdr1014_en_US.apm_files

OT: Only FYI
APUP 1.4.14 chokes big time when attempting to run a local script. I got so many error dialogs I had to stop apup.exe via task manager. curl.exe never started. My apup.log file was over 1250 lines of error messages, here's the log. I edited the log because the second group of errors ("at line 130" thru "at line 126") simply repeat. Depending on when I stopped the apup.exe process, the log would end abruptly with an "at line" comment, nothing else.

Spoiler

APUP Has Started
Version: 1.4.14

Operating System: English (1033) Windows XP Professional Service Pack 2
Current Locale: English - United States / Non-Unicode Default: English - United States
Starting APUP From: C:\apup
Date & Time: 31-Mar-2013 19:25 UTC Offset: -8

Local script file specified, skipping HTTP release list!
Using local script file: C:\apup\off_addon_1.script
Nothing To Download. Proceeding to next phase.

Error: Subscript out of range
in prjUpdater.mdlScriptParser.verifyScriptDownloads at line 104
Error: Subscript out of range
in prjUpdater.mdlScriptParser.verifyScriptDownloads at line 106
Error: Subscript out of range
in prjUpdater.mdlScriptParser.verifyScriptDownloads at line 108
Error: Subscript out of range
in prjUpdater.mdlScriptParser.verifyScriptDownloads at line 110
Error: Subscript out of range
in prjUpdater.mdlScriptParser.verifyScriptDownloads at line 112
Error: Subscript out of range
in prjUpdater.mdlScriptParser.verifyScriptDownloads at line 114
Error: Subscript out of range
in prjUpdater.mdlScriptParser.verifyScriptDownloads at line 116
Error: Subscript out of range
in prjUpdater.mdlScriptParser.verifyScriptDownloads at line 118
Error: Object variable or With block variable not set
in prjUpdater.mdlScriptParser.verifyScriptDownloads at line 120
Error: Subscript out of range
in prjUpdater.mdlScriptParser.verifyScriptDownloads at line 122
Error: Object variable or With block variable not set
in prjUpdater.mdlScriptParser.verifyScriptDownloads at line 124
Error: Object variable or With block variable not set
in prjUpdater.mdlScriptParser.verifyScriptDownloads at line 126

Error: Subscript out of range
in prjUpdater.mdlScriptParser.verifyScriptDownloads at line 130
Error: Subscript out of range
in prjUpdater.mdlScriptParser.verifyScriptDownloads at line 132
Error: Subscript out of range
in prjUpdater.mdlScriptParser.verifyScriptDownloads at line 114
Error: Subscript out of range
in prjUpdater.mdlScriptParser.verifyScriptDownloads at line 116
Error: Subscript out of range
in prjUpdater.mdlScriptParser.verifyScriptDownloads at line 118
Error: Object variable or With block variable not set
in prjUpdater.mdlScriptParser.verifyScriptDownloads at line 120
Error: Subscript out of range
in prjUpdater.mdlScriptParser.verifyScriptDownloads at line 122
Error: Object variable or With block variable not set
in prjUpdater.mdlScriptParser.verifyScriptDownloads at line 124
Error: Object variable or With block variable not set
in prjUpdater.mdlScriptParser.verifyScriptDownloads at line 126

... repeat of second "Subscript out of range" errors

... again

... and again

...

I might have been able to shut down APUP via a button, "Quit", "Exit" ..., but recent updates to apup.exe start the process and hide the GUI - yuck! I had to resort to using an older APUP just to be able to successfully run a script locally when tesing - I wish the newer APUP would stay visible, IMO.

Like I said, only FYI & IMO.

[_def_x_]

DesertJerry, on 01 April 2013 - 04:05 AM, said:

As I said earlier - I ran APUP 1.4.14 with Options set to Releases2.list and I selected the Office update - I did not get the _v2 version.

Your ISP or your system has cached an old version of releases2.list. I would clear out your cache using CCleaner and try again.

[ViroMan]

The internal preaction file and folder deletes will not show... unless it actually has something to delete. All preaction dos commands are shown.

For the local script issue... thanks for the heads up.. will look into it. Adding to top of todo list.

As for the hiding the gui... It shouldn't hide unless you pass in /auto in the command line. Will have to look into it.(I faintly remember a similar issue)

[ViroMan]

I found where it has issues with the local script. I fixed it but, need to go around and make sure things happen when they should. Skipping strait to parsing the script instead of going through the other motions makes some things not happen in exact order.

[_def_x_]

ViroMan, on 01 April 2013 - 04:52 AM, said:

The internal preaction file and folder deletes will not show... unless it actually has something to delete. All preaction dos commands are shown.

It never mattered before, I've been using the code examples above for a long time, maybe the internal code has changed recently. I scantly use AutoPatcher/APUP anymore so I'm truly out of the loop. The first set would write to the log no matter how many times the script ran. We asked users to run APUP at least twice to clear the log. It would clear the log of downloads, not deletes. The second set would not write to the log regardless how many times the script was run.

An example of this can be seen in the spoiler code of the sticky - http://www.autopatch...es-please-read/ - notice there is only one file to download, this was not a first run, and the deletions are written to the log.

Sweeper is a nice alternative, writes a log file etc, but a user must run Sweeper to do any cleaning. I like to have both options, including searching the apup.log for problems.

ViroMan, on 01 April 2013 - 04:52 AM, said:

For the local script issue... thanks for the heads up.. will look into it. Adding to top of todo list.

C:\apup\apup.exe /localscript:C:\apup\off_addon_1.script
C:\apup\apup.exe /log /localscript:C:\apup\off_addon_2.script

I would use /log with versions of APUP that didn't automatically create a log file.

ViroMan, on 01 April 2013 - 04:52 AM, said:

As for the hiding the gui... It shouldn't hide unless you pass in /auto in the command line. Will have to look into it.(I faintly remember a similar issue)

I've never used /auto - see above.

I'm not wanting to be argumentative, only want to stress I've had to be creative when building scripts from scratch (dialup) - building scripts encrementally, running locally, and the option to quit APUP via the GUI were very useful, and both of these features have become more and more problematic as APUP matures in other areas.

Anyway, only FYI.

[ViroMan]

No, I fully accept your input as useful since there are not many who would say anything, so I do not know there is something wrong or not liked. Squeaky wheel gets the oil so to speak, yes?

Quote

It never mattered before,

The reason it never mattered before is because the internal commands didn't work so only dos commands were used. Since I have been fixing up the internal commands I have been switching scripts to use the internal commands for two reason 1) I can receive better errors and have control of what goes on 2) so the log is not cluttered up as much with things that may not have happened(deleting a file not there). If you would prefer to have more in the log that can be arranged.

Quote

I've never used /auto - see above.

I believe you, that is why I say I will have to look into it. I do think I came across this issue before.

Edited by ViroMan, 01 April 2013 - 07:30 AM.

[DesertJerry]

_def_x_, on 01 April 2013 - 04:28 AM, said:

Your ISP or your system has cached an old version of releases2.list. I would clear out your cache using CCleaner and try again.

My \Temporary Internet Files folder is on a RAMDRIVE and is, therefore, cleared out during every boot/reboot - I don't believe that is the problem.

[DesertJerry]

Seems to be an unnecessary difference in the Titles.
Win7 Ultimate 64bit w/SP1 > AutoPatcher v5.7.31 > Windows Addons:
Microsoft Visual C++ 2012 SP1 Security Update Redistributable x64 (I added the x64 to the Title line in the APM to determine what was going on)
and
Microsoft Visual C++ Redistributable for Visual Studio 2012 x86 (I added the x86 to the Title line in the APM to determine what was going on)
vcredist_2012_x64.apm shows:
[General]
Title=Microsoft Visual C++ 2012 SP1 Security Update Redistributable x64
Description=The Visual C++ Redistributable Packages install runtime components that are required to run C++ applications built with Visual Studio 2012.
vcredist_2012_x86.apm shows:
[General]
Title=Microsoft Visual C++ Redistributable for Visual Studio 2012 x86
Description=The Visual C++ Redistributable Packages install runtime components that are required to run C++ applications built with Visual Studio 2012.
Notice that both Descriptions describe the same function and a review of the two APMs in question shows KeyValues for each have identical versions.
Therefore, to be consistent with how other Visual C++ programs are listed and to stop the confusion change:
Title=Microsoft Visual C++ Redistributable for Visual Studio 2012 x86
to read:
Title=Microsoft Visual C++ 2012 SP1 Security Update Redistributable x86